fix(modern-compiler): dispose redundant compilers - #1245
Merged
alexander-akait merged 3 commits intoNov 1, 2024
Conversation
evenstensberg
left a comment
evenstensberg
left a comment
Member
There was a problem hiding this comment.
Could you sign the CLA?
Contributor
Author
|
Sure, signed it. |
evenstensberg
approved these changes
Oct 31, 2024
evenstensberg
previously approved these changes
Oct 31, 2024
| compiler.dispose(); | ||
| }); | ||
| } else { | ||
| compiler.dispose(); |
Member
There was a problem hiding this comment.
I'm not a fan of if/elses deeply nested, but we can't return early in this scope, so it's okay.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1245 +/- ##
==========================================
- Coverage 94.44% 94.23% -0.22%
==========================================
Files 3 3
Lines 360 416 +56
Branches 132 158 +26
==========================================
+ Hits 340 392 +52
- Misses 18 22 +4
Partials 2 2 ☔ View full report in Codecov by Sentry. |
Member
|
Seems like the coverage is failing here. Could you add a test for this? |
alexander-akait
left a comment
alexander-akait
left a comment
Member
There was a problem hiding this comment.
I will add a test case
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains a:
idk how to cover this by tests
Motivation / Use-Case
fixes #1244
Breaking Changes
No
Additional Info
No